make pickleStepIDs unique accross multiple paths#366
Merged
lonnblad merged 3 commits intocucumber:masterfrom Dec 16, 2020
Merged
make pickleStepIDs unique accross multiple paths#366lonnblad merged 3 commits intocucumber:masterfrom
lonnblad merged 3 commits intocucumber:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 79.12% 81.03% +1.90%
==========================================
Files 25 25
Lines 1993 1993
==========================================
+ Hits 1577 1615 +38
+ Misses 320 275 -45
- Partials 96 103 +7
Continue to review full report at Codecov.
|
Contributor
|
Hi @rickardenglund, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into trouble with pickleStepID not being unique when having the feature files on multiple paths.
In the failing scenario we have a bunch of features distributed along multiple paths.
I experienced a nil pointer dereference in the pretty printer when executing a scenario outline pickle.
The pickleStep received from
pickleStep = f.storage.MustGetPickleStep(result.PickleStepID)was originating from a different feature from a different path