Conversation
- Working example where the custom formatter is built on top of the Progress formatter, using emojis instead of text
Member
Author
|
If this is a non-starter, please let me know :) |
|
Is this issue still in progress? |
Member
|
Hi, I'm one of the Cucumber org's maintainers. We're short on regular maintainers for godog at the moment so sorry for the delay getting this reviewed. I'm happy to merge this if someone can rebase it. |
|
I will give it a try and test with one of my own formatters |
# Conflicts: # _examples/custom-formatter/custom.go # _examples/custom-formatter/go.mod # internal/formatters/fmt_events.go # internal/formatters/fmt_pretty.go # internal/formatters/fmt_progress.go
WIP 368 public formatter
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 83.07% 82.69% -0.39%
==========================================
Files 26 26
Lines 2511 2525 +14
==========================================
+ Hits 2086 2088 +2
- Misses 328 340 +12
Partials 97 97
Continue to review full report at Codecov.
|
6 tasks
vearutop
approved these changes
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368
This PR exposes Godog formatters, making them embeddable by custom formatters