Fix tests and CircleCI jobs#404
Conversation
|
Oh, actually the problem is bigger. Latest commit in |
…nts have changed since last read"
…nts have changed since last read"
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 81.13% 80.81% -0.32%
==========================================
Files 25 26 +1
Lines 1998 2033 +35
==========================================
+ Hits 1621 1643 +22
- Misses 274 287 +13
Partials 103 103
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| return bg | ||
| return nil |
There was a problem hiding this comment.
This change reverts 5414f3c#diff-11cc1058f443cce780d83b56496302454770d91e64cd1f228d2d45d38598e9a4R41 so that original test passes.
@mbow could you please check if that change was intended?
| dir := filepath.Join(os.TempDir(), t.Name()) | ||
| err := os.MkdirAll(dir, 0755) | ||
| require.NoError(t, err) | ||
|
|
||
| defer os.RemoveAll(dir) | ||
|
|
||
| file := filepath.Join(dir, "result.xml") |
There was a problem hiding this comment.
This change reverts usage of t.TempDir() to support go1.13 where the function is not available.
| github.com/cucumber/gherkin-go/v11 v11.0.0 // indirect | ||
| github.com/cucumber/godog v0.10.1-0.20210705192606-df8c6e49b40b | ||
| github.com/cucumber/messages-go/v10 v10.0.3 // indirect | ||
| github.com/cucumber/messages-go/v16 v16.0.1 | ||
| github.com/hashicorp/go-immutable-radix v1.3.1 // indirect | ||
| github.com/hashicorp/go-memdb v1.3.2 // indirect |
There was a problem hiding this comment.
This change pinpoints a not yet released version of github.com/cucumber/godog to resolve import dependency on github.com/cucumber/messages-go/v16.
There was a problem hiding this comment.
I don't want this PR to snowball, but is #389 worth bearing in mind here if we're changing the dependencies?
There was a problem hiding this comment.
As far as I understood, the idea of #389 is to start using github.com/cucumber/common/messages/go/v16 packages instead of github.com/cucumber/messages-go/v16.
I think such change should to be delivered in separate PR to change all relevant imports of the github.com/cucumber/godog.
Current change is only a fix in one of examples provided by godog which is organized as a separate module and so does not inherit parent (godog) module dependencies. Previously this example was using godog v0.11.0, but at the same was using messages-go/v16 that was only supported by newer (untagged) version of godog.
In this situation we have 3 options in my opinion:
- revert example to use
messages-go/v10so that it is again compatible withgodogv0.11.0, - update example to use pinned commit for newer
godog(as done in this PR), - remove
go.modfrom example, so that it inherits parent dependencies.
There was a problem hiding this comment.
As far as I understood, the idea of #389 is to start using github.com/cucumber/common/messages/go/v16 packages instead of github.com/cucumber/messages-go/v16.
That's right
I think such change should to be delivered in separate PR to change all relevant imports of the github.com/cucumber/godog.
👍
|
@vearutop I can't do any kind of meaningful review on this as I don't know the codebase. You have the commit bit, so if you're happy with I suggest you go ahead and merge. If you have specific things you want feedback on first, please ask! |
2 participants
Description
Current
mainfails CI jobs since recent merges.Motivation & context
This PR
gofmtformatting where missing,go1.16home directory configuration in CI,MultiFormatterwas depending on obsolete (v10instead ofv16) version ofmessages-go,go mod tidyto comply with No automatic changes to go.mod and go.sum,Type of change
Note to other contributors
No notes.
Update required of cucumber.io/docs
Not required.
Checklist: