Add scenario hook errors to first and last steps#417
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 82.75% 83.07% +0.31%
==========================================
Files 26 26
Lines 2459 2511 +52
==========================================
+ Hits 2035 2086 +51
- Misses 327 328 +1
Partials 97 97
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes contextualized hooks introduced in #409 in the way how errors are handled.
Motivation & context
Original implementation of new hooks did not provide enough visibility to errors emitted by scenario hooks.
Test run would fail silently with all steps passed.
This PR changes errors handling to leverage closest step to communicate hook failure.
For the
Afterscenario hook, errors are added to the last evaluated step.For the
Beforescenario hook, errors are added to the first step.Type of change
Note to other contributors
No note.
Update required of cucumber.io/docs
No update.
Checklist: