ci: Run yarn before running Storybook#616
Merged
ActuallyACat merged 4 commits intomasterfrom Jul 6, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
We've had a query about storybook not working locally, which is a result of developers not running
yarn installafter pulling a branch. This PR addsyarn installto thestorybookscript.I was initially worried this would add extra time to run storybook, but in real terms it only adds an additional ~1-2s to the script (assuming the branch is up to date):
In my first attempt I wrote a bash script that runs
yarn check --integrity, but that will be removed in the near future, and takes a little bit of time.