Skip to content

ci: Run yarn before running Storybook#616

Merged
ActuallyACat merged 4 commits intomasterfrom
ally/install-check
Jul 6, 2020
Merged

ci: Run yarn before running Storybook#616
ActuallyACat merged 4 commits intomasterfrom
ally/install-check

Conversation

@ActuallyACat
Copy link
Copy Markdown
Contributor

@ActuallyACat ActuallyACat commented Jul 3, 2020

About

We've had a query about storybook not working locally, which is a result of developers not running yarn install after pulling a branch. This PR adds yarn install to the storybook script.

I was initially worried this would add extra time to run storybook, but in real terms it only adds an additional ~1-2s to the script (assuming the branch is up to date):

$ time yarn
yarn install v1.22.4
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.97s.

real    0m1.282s
user    0m1.589s

In my first attempt I wrote a bash script that runs yarn check --integrity, but that will be removed in the near future, and takes a little bit of time.

@ActuallyACat ActuallyACat changed the title Ally/install check ci: Run yarn before running Storybook Jul 3, 2020
Copy link
Copy Markdown
Contributor

@mbylstra mbylstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@ActuallyACat ActuallyACat merged commit 16c1844 into master Jul 6, 2020
@ActuallyACat ActuallyACat deleted the ally/install-check branch July 6, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants