Skip to content

Support #allow-multiple! predicate to enable multiple content ranges #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pokey
Copy link
Member

@pokey pokey commented May 26, 2023

Checklist

Sorry, something went wrong.

@pokey pokey force-pushed the pokey/support-child-range-predicate branch from 5c95c7c to fcdfe95 Compare May 26, 2023 16:26
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 2 times, most recently from 2d7926c to 29d4cfb Compare May 26, 2023 17:45
@pokey pokey force-pushed the pokey/support-child-range-predicate branch 2 times, most recently from 4664603 to fc07758 Compare May 26, 2023 17:48
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 3 times, most recently from 1e3dafd to f9e078a Compare May 28, 2023 13:46
@pokey pokey force-pushed the pokey/support-child-range-predicate branch from 6e75152 to 84f562b Compare May 28, 2023 13:46
@pokey pokey changed the base branch from pokey/support-child-range-predicate to pokey/support-multiple-targets-per-scope May 28, 2023 13:47
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from f9e078a to 1534625 Compare May 28, 2023 13:51
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from 84aeab2 to 04cf9b8 Compare May 28, 2023 13:51
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 3 times, most recently from 7412fdb to cfb064f Compare May 28, 2023 14:23
@pokey pokey mentioned this pull request May 28, 2023
3 tasks
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 2 times, most recently from b952885 to b1b0972 Compare May 28, 2023 14:34
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch 2 times, most recently from 23fcbff to 7f02822 Compare May 28, 2023 14:40
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from b1b0972 to 6910a8e Compare May 28, 2023 14:40
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from 7f02822 to da0805c Compare May 28, 2023 14:44
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 6910a8e to bc6397c Compare May 28, 2023 14:44
@pokey pokey requested a review from AndreasArvidsson May 28, 2023 14:46
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from bc6397c to 683d715 Compare May 28, 2023 15:25
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from da0805c to df5c834 Compare May 30, 2023 01:17
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 9e7d2d6 to 8c319cd Compare May 30, 2023 01:17
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from df5c834 to c6e6679 Compare May 30, 2023 14:53
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 3 times, most recently from e88e30b to 96b8a8d Compare June 1, 2023 18:46
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch 2 times, most recently from 255c71d to fbc0e27 Compare June 1, 2023 18:55
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 96b8a8d to 17f9d57 Compare June 1, 2023 18:55
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from fbc0e27 to 8734be6 Compare June 1, 2023 21:05
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch 2 times, most recently from 0aa109c to 788bfc8 Compare June 4, 2023 00:05
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch 2 times, most recently from 726f7c2 to ba21794 Compare June 5, 2023 10:49
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 788bfc8 to 16c5d57 Compare June 5, 2023 10:49
@pokey pokey force-pushed the pokey/support-multiple-targets-per-scope branch from ba21794 to c64f7b4 Compare June 6, 2023 10:41
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 16c5d57 to 1471635 Compare June 6, 2023 10:41
Base automatically changed from pokey/support-multiple-targets-per-scope to main June 6, 2023 11:18
pokey added 2 commits June 6, 2023 07:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pokey pokey marked this pull request as ready for review June 6, 2023 11:23
@pokey pokey enabled auto-merge June 6, 2023 11:23
@pokey pokey force-pushed the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch from 1471635 to dd47c00 Compare June 6, 2023 11:26
@pokey pokey added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit f759734 Jun 6, 2023
@pokey pokey deleted the pokey/support-allow-multiple-predicate-to-enable-multiple-content-ranges branch June 6, 2023 11:57
pokey added a commit that referenced this pull request Jun 6, 2023
- Fixes #1478
- Depends on #1507

## Checklist

- [x] Support "every name" while we're here
   - [x] Arg lists
   - [x] Functions in class
   - [x] Assignment statements in function body
   - [x] Assignment statements at top level
   - [x] Properties in class
   - [x] Members of interface
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants