-
Notifications
You must be signed in to change notification settings - Fork 49
docs: Corrected the font paths, right aligned the top navbar items #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
@@ -155,13 +155,13 @@ reference: | |||
navbar: | |||
structure: | |||
left: | |||
right: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this I'm not sure the maintainer wants to change. that's something pkgdown website maintainers can change as they will. Unless it looks really awful with the current design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can achieve the designer's intention by treating all "left" items as if they were "right" items. I'd rather not adapt _pkgdown.yml
in every package that uses the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in that case we'd need to provide a wrapper around pkgdown::build_site()
within cynkratemplate. That's what rotemplate, the rOpenSci's pkgdown template, does. But it means we'd have to tweak all package repos to use that... so in the end, easier to tweak YAML configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please:
- No wrapper
- No config changes
Pretty sure we can adapt the template, let's discuss there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me tweak the cynkratemplate PR
@talpitoo: Does https://dm.cynkra.com/dev/ look the way it should? If yes, we can close this PR. |
This PR repeats the same patterns made in cynkra/cynkratemplate#58 (once that is merged as the parent template).