Skip to content

docs: Corrected the font paths, right aligned the top navbar items #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

talpitoo
Copy link
Collaborator

@talpitoo talpitoo commented Apr 5, 2025

This PR repeats the same patterns made in cynkra/cynkratemplate#58 (once that is merged as the parent template).

Copy link
Contributor

aviator-app bot commented Apr 5, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@@ -155,13 +155,13 @@ reference:
navbar:
structure:
left:
right:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this I'm not sure the maintainer wants to change. that's something pkgdown website maintainers can change as they will. Unless it looks really awful with the current design?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can achieve the designer's intention by treating all "left" items as if they were "right" items. I'd rather not adapt _pkgdown.yml in every package that uses the template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in that case we'd need to provide a wrapper around pkgdown::build_site() within cynkratemplate. That's what rotemplate, the rOpenSci's pkgdown template, does. But it means we'd have to tweak all package repos to use that... so in the end, easier to tweak YAML configs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • No wrapper
  • No config changes

Pretty sure we can adapt the template, let's discuss there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me tweak the cynkratemplate PR

@krlmlr krlmlr changed the title corrected the font paths, right aligned the top navbar items docs: Corrected the font paths, right aligned the top navbar items Jul 1, 2025
@krlmlr
Copy link
Collaborator

krlmlr commented Jul 1, 2025

@talpitoo: Does https://dm.cynkra.com/dev/ look the way it should? If yes, we can close this PR.

@krlmlr krlmlr marked this pull request as draft July 1, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants