Skip to content

Restore missing DefaultForegroundColor#209

Merged
dahlbyk merged 1 commit intomasterfrom
RestoreDefaultForegroundColor
Aug 25, 2015
Merged

Restore missing DefaultForegroundColor#209
dahlbyk merged 1 commit intomasterfrom
RestoreDefaultForegroundColor

Conversation

@dahlbyk
Copy link
Copy Markdown
Owner

@dahlbyk dahlbyk commented Aug 25, 2015

Removed in #202.

This may only impact me, but I'm getting an error in the GitHub for Windows shell because my local settings is missing this now-obsolete property. Maybe we can remove it eventually, but for now it's safer to leave it in.

Exception setting "ForegroundColor": "Cannot convert null to type "System.ConsoleColor" due to enumeration values that
are not valid. Specify one of the following enumeration values and try again. The possible enumeration values are
"Black, DarkBlue, DarkGreen, DarkCyan, DarkRed, DarkMagenta, DarkYellow, Gray, DarkGray, Blue, Green, Cyan, Red,
Magenta, Yellow, White"."
At C:\Users\Keith\AppData\Local\GitHub\PoshGit_869d4c5159797755bc04749db47b166136e59132\profile.example.ps1:16 char:5
+     $Host.UI.RawUI.ForegroundColor = $GitPromptSettings.DefaultForegroundColor

dahlbyk added a commit that referenced this pull request Aug 25, 2015
@dahlbyk dahlbyk merged commit fc7c407 into master Aug 25, 2015
@dahlbyk dahlbyk deleted the RestoreDefaultForegroundColor branch August 25, 2015 03:56
dahlbyk added a commit that referenced this pull request Mar 4, 2017
The setting exists for legacy reasons: 02956e1.
It was removed in #202 and restored in #209 to avoid a breaking change.

Since we still have it, I suppose we might as well support using it to
control the prompt text color.
dahlbyk added a commit that referenced this pull request Mar 4, 2017
The setting exists for legacy reasons: 02956e1.
It was removed in #202 and restored in #209 to avoid a breaking change.

Since we still have it, I suppose we might as well support using it to
control the prompt text color.
dahlbyk added a commit that referenced this pull request Mar 4, 2017
The setting exists for legacy reasons: 02956e1.
It was removed in #202 and restored in #209 to avoid a breaking change.

Since we still have it, I suppose we might as well support using it to
control the prompt text color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant