Conversation
Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).
rkeithhill
force-pushed
the
rkeithhill/remove-PS2.0-support
branch
from
52e7296 to
cf148fd
Compare
|
|
||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
We probably want to keep both master and develop. That change may also need to find its way into master (the default branch) for it to take effect (not certain about that).
There was a problem hiding this comment.
Ideally there would be a way in appveyor.yml to specify the "current target branch". So if we put in both master and develop will that attempt to build a PR meant for develop on master also? If so, that would likely fail. Then again, I'm a total AppVeyor n00b.
There was a problem hiding this comment.
It just means any change in master or develop will be built. We will probably want to add a badge for develop, too.
PRs are built regardless of target; this setting is (ideally) only for merged PRs.
src/posh-git.psd1
Outdated
|
|
||
| # Version number of this module. | ||
| ModuleVersion = '0.7.0' | ||
| ModuleVersion = '1.0.0' |
There was a problem hiding this comment.
Really wish this supported a prerelease suffix. I'd like to be able to differentiate between folks using a PowerShell Gallery version and this branch. Maybe use 1.0.0.0 and then switch to 1.0.0 when the time comes to release?
There was a problem hiding this comment.
'1.0.0' comes out as version 1.0.0.-1 so the order between release and pre is wrong. :-(
We can add a field to the module manifest private data to indicate a PrereleaseVersion string that we could retrieve with (gmo posh-git).PrivateData.PSData.PrereleaseVersion.
There was a problem hiding this comment.
I am mostly concerned with the issue template version script showing a difference between loading from develop/master and from Chocolatey or the Gallery.
An alternative would be to include the posh-git module's path, perhaps with a replacement of $Home with ~?
There was a problem hiding this comment.
'1.0.0' comes out as version 1.0.0.-1 so the order between release and pre is wrong.
It may actually be desirable for a local version (think fork with personalized features) to win out over an official version (e.g. inherited from GitHub Desktop). Maybe? Of course the personalized fork could just bump the version...
There was a problem hiding this comment.
The way I handle that scenario is to import by path e.g:
Import-Module $Home\GitHub\dahlbyk\posh-git\src\posh-git.psd1Development is in the works for PowerShellGet/PSGallery to support prereleases. I'm hoping this problem will get solved in the coming months. PowerShell/PowerShell-RFC#42
There was a problem hiding this comment.
Yes, but doing that if posh-git has already been loaded, e.g. in the GitHub Desktop shell, leaves you with two posh-git modules loaded. If one of those is 0.7.0 and the other is a personal fork that also reports 0.7.0, I have to check path to differentiate. Thus my suggestion of the extra .0 as a hint that this isn't an official version.
That said, also including PrereleaseVersion makes sense… add that to the issue template script?
There was a problem hiding this comment.
OK. But I'll update the issue template file on master in a separate PR. Also, regarding those extra commands to not export. I'll remove those. I'm guilty of adding Get-GitBranch for testing purposes but I think Pesters's InModuleScope will get me access to this function.
There was a problem hiding this comment.
What if we leave in Write-Prompt to abstract the difference between using Write-Host and ANSI escape sequences. Folks customizing their own prompt function might find that useful.
|
|
||
| # Aliases to export from this module | ||
| AliasesToExport = @('??') | ||
| AliasesToExport = @() |
There was a problem hiding this comment.
Remove until we stumble on an alias we want to export (unlikely)?
There was a problem hiding this comment.
An empty array helps with overall system performance.
If you omit the entry, PowerShell does more expensive work to see if you meant to export any aliases.
| <id>poshgit</id> | ||
| <title>posh-git</title> | ||
| <version>0.7.0</version> | ||
| <version>1.0.0-pre00</version> |
Also add PrereleaseVersion as module private data property. Might come in handy. I'll update the issue template on master and then submit a PR to merge master to develop.
|
So build is green here, but failed on |
|
Yup. Could be the switch to using InModuleScope to access the Get-GitBranch function (as opposed to exporting it). |
I wouldn't expect that to have passed in the PR build. My guess is it's due to building on |
|
Was just looking more closely at the error messages. It doesn't like creating |
|
I can run these tests locally on both master and develop and they all pass. This must have something to do with how AppVeyor sets up the build/test environment. For instance, when it uses develop, I see failures like this: Is it fetching develop only and not master as well? |
|
|
|
Yeah, my bad. Thanks for the help on this! |
|
PR opened into |
3 participants
Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).
Checkout the version number (1.0.0-pre00) in the chocolatey/poshgit.nuspec file. Not sure which version of NuGet is being used but if v2, I think the prelease string uses a simple lexicographic sort so that pre10 would sort below pre9. I suspect 1.0 could have more than 10 prerelease choco drops. I hope not more than 100 though. :-)
cc #163