Skip to content

fix(status): Only reset changed colors#673

Merged
rkeithhill merged 5 commits intodahlbyk:masterfrom
EB-Forks:fix/no-style-overreset
Jun 23, 2019
Merged

fix(status): Only reset changed colors#673
rkeithhill merged 5 commits intodahlbyk:masterfrom
EB-Forks:fix/no-style-overreset

Conversation

@ExE-Boss
Copy link
Copy Markdown
Contributor

@ExE-Boss ExE-Boss commented Apr 3, 2019

This fixes a bug with using posh‑git inside a PowerLine block, which would result in the background colour being reset to the PowerShell window’s background colour, breaking the PowerLine block.

review?(@dahlbyk): I’ve been using this for the last 15 days, and it works fine for me.

Copy link
Copy Markdown
Owner

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @ExE-Boss. I've been focused on wrapping up a big project.

I can reproduce the build failure on master, so I'll merge as soon as we can get that resolved. Thanks for the contribution!

@rkeithhill
Copy link
Copy Markdown
Collaborator

That build failure seems to be because apt-get is failing to install PowerShell on Ubuntu 14.04. Any chance we could migrate the build to 16.04 since 14.04 is EOL in 10 days? Install instructions for 16.04 are here - https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-linux?view=powershell-6#installation-via-package-repository---ubuntu-1604

Copy link
Copy Markdown
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rkeithhill rkeithhill merged commit 5d2ffbe into dahlbyk:master Jun 23, 2019
@ExE-Boss ExE-Boss deleted the fix/no-style-overreset branch June 24, 2019 00:36
@dahlbyk dahlbyk added this to the v1.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants