Conversation
|
@dahlbyk Ran across this which explains why we did this (and is another complaint requesting we don't do this) #153. The git.exe wrapper that comes with Git for Windows sets the HOME env var for its process. Is this sufficient? Or do other Git impls for Windows (msys, mingw, etc) require this? If so, I think we should make creation of the HOME env var conditional (or maybe we warn as you suggest in the other issue). |
Modified after reviewing issue #153
|
Creating the HOME variable is problematic for entirely unrelated programs (such as Azure DevOps command line utilities), where it overrides its normal placement of config files. So enabling posh git might make things stop working. I'd prefer that posh-git never set that variable; it's not needed for git now. See also #718. |
|
@cyanite Going to go with not setting this env var at all. I agree that it doesn't seem like something that |
|
I'm good with removing this. As I noted forever ago in #153 (comment), this was in imitation of Git shims that are no longer relevant. |
Windows does not normally define a
HOMEenv var so we are always defining that env var. We should be using PowerShell's built-in variable$HOMEinstead.Fixes #718