Put 'CACHE ERROR' in prompt when cache returns failure.#759
Merged
dahlbyk merged 1 commit intodahlbyk:masterfrom Apr 8, 2020
Merged
Put 'CACHE ERROR' in prompt when cache returns failure.#759dahlbyk merged 1 commit intodahlbyk:masterfrom
dahlbyk merged 1 commit intodahlbyk:masterfrom
Conversation
Collaborator
Collaborator
Author
|
TIL! Thanks! |
Collaborator
|
I really wish GitHub would offer the option to ignore whitespace changes in diffs. This is one area where Bitbucket has a leg up on GH. |
Collaborator
|
Thanks for the PR! I've asked the other Keith to review it before merging it. |
Owner
|
Thanks for the fix, @cmarcusreid!
You have been able to add |
Collaborator
|
Thanks for pointing that out! That has been bugging me for a while. I was looking in the wrong place - in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Follow-up from #755
This diff is a bit unfortunate; the only new bit is the leading if block. The rest was indented in the new else block.