Skip to content

Be sure to honor EnableStashStatus when using cache#762

Merged
rkeithhill merged 1 commit intomasterfrom
rkeithhill/honor-enablestashstatus-setting
Apr 12, 2020
Merged

Be sure to honor EnableStashStatus when using cache#762
rkeithhill merged 1 commit intomasterfrom
rkeithhill/honor-enablestashstatus-setting

Conversation

@rkeithhill
Copy link
Copy Markdown
Collaborator

Fix #761

@rkeithhill rkeithhill requested a review from cmarcusreid April 12, 2020 01:50
@rkeithhill rkeithhill merged commit 14e274d into master Apr 12, 2020
@rkeithhill rkeithhill deleted the rkeithhill/honor-enablestashstatus-setting branch April 12, 2020 04:22

if ($cacheResponse.Stashes) { $stashCount = $cacheResponse.Stashes.Length }
if ($cacheResponse.State) { $branch += "|" + $cacheResponse.State }
if ($settings.EnableStashStatus -and $cacheResponse.Stashes) {
Copy link
Copy Markdown
Owner

@dahlbyk dahlbyk Apr 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @cmarcusreid gets bored, the API could conceivably receive request options like this to prevent the cache from doing background work the user doesn't care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using git-status-cache stash settings are not respected

3 participants