Chore: Upgrade GitBeaker dependency to 43.8.0

[glensc]

Major release notes:

• 39.0.0
  • @gitbeaker/core: Renaming downloadTraceFile to showLog and updating return type Renaming downloadTraceFile to showLog and updating return type jdalrymple/gitbeaker#3301 (@jdalrymple)
• 40.0.0
  • @gitbeaker/core: Updating Access Token API wrapper Updating Access Token API wrapper jdalrymple/gitbeaker#3554 (@jdalrymple)
• 41.0.0
  • @gitbeaker/core, @gitbeaker/rest: Adding support for GroupJobTokenScopes and moved JobTokenScopes to ProjectJobTokenScopes(Adding support for GroupJobTokenScopes and moved JobTokenScopes to ProjectJobTokenScopes(#3643) jdalrymple/gitbeaker#3643) Adding support for GroupJobTokenScopes and moved JobTokenScopes to ProjectJobTokenScopes(#3643) jdalrymple/gitbeaker#3643 (@jdalrymple)
• 42.0.0
  • @gitbeaker/core: Accept username in ProjectMembers#add Accept username in ProjectMembers#add jdalrymple/gitbeaker#3666 (@talyssonoc @jdalrymple)
• 43.0.0
  • @gitbeaker/rest: Enhance error messaging in GitbeakerRequestError to clearly display only the description context Enhance error messaging in GitbeakerRequestError to clearly display only the description context jdalrymple/gitbeaker#3731 (@kang8)

Refs

• [DEPS] Move from @gitbeaker/node to @gitbeaker/rest #1386

[glensc]

I don't know why CI fails. Help appreciated.

[fbartho]

@glensc I'm not sure what the question is; it looks like many of the _gitlab_api.test.ts test cases are throwing the same error: "TypeError: Only absolute URLs are supported"

Tracing the first test case:

danger-js/source/platforms/gitlab/_tests/_gitlab_api.test.ts

Lines 83 to 91 in a9f198a

	it("getUser returns the current user profile id", async () => {
	// To re-record this you need to provide a valid DANGER_GITLAB_API_TOKEN
	const { nockDone } = await nockBack("getUser.json", { afterRecord: sanitizeUserResponse })
	const result = await api.getUser()
	nockDone()
	const { response } = loadFixture("getUser")
	expect(result).toEqual(response)
	})

This calls through the platform to the GitLab adapter:

danger-js/source/platforms/gitlab/GitLabAPI.ts

Lines 100 to 105 in a9f198a

	getUser = async (): Promise<Types.ExpandedUserSchema> => {
	this.d("getUser")
	const user = (await this.api.Users.showCurrentUser()) as Types.ExpandedUserSchema
	this.d("getUser", user)
	return user
	}

So I suspect the gitlab API (or more likely gitbreaker itself) is throwing an error at this.api.Users.showCurrentUser()

What do you think?

[fbartho]

Alternatively, the issue is with nock's integration into the codebase. That is a dependency that is only used by the GitLab API.

Custom testing tools for test infrastructure only used by a single platform (that is experiencing errors) makes me suspicious. Generic testing tools might not expect the DangerJS runtime.

Was nock necessary? Don't we have other tools in the repo that accomplish the same objective?

[glensc]

"I don't know" was perhaps too short a message.

I tried to update nock integration, but my changes had no effect (sorry, I don't have them around). also tried to compare git diffs between breaking versions (38..39) and found nothing obvious.