Skip to content

Conversation

@danny-avila
Copy link
Owner

Summary

I fixed several state management issues affecting file uploads and tool authentication flows in the application.

  • Reset ephemeral agent state for tools when authentication fails to prevent incorrect UI state persistence
  • Update ephemeral agent state specifically for execute_code tool when file upload errors occur
  • Ensure loading state is correctly set to false when files array is empty
  • Set loading state to true when files are still in progress of uploading

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested these changes by:

  1. Attempting to use tools that require authentication without being authenticated
  2. Uploading files with the execute_code tool enabled and triggering upload failures
  3. Monitoring the loading state when clearing all files and during file upload progress

Test Configuration:

  • Tested with various file types and sizes
  • Tested authentication flow with multiple tool configurations
  • Verified state consistency across component re-renders

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit a26597a into dev Aug 29, 2025
6 checks passed
@danny-avila danny-avila deleted the refactor/file-upload-ux branch August 29, 2025 03:11
@DmitriyAlergant
Copy link

Thanks! Impressive speed to react and resolve the otherwise minor issue. Genuinely impressed.

Thank you for your work.

lihe8811 pushed a commit to lihe8811/LibreChat that referenced this pull request Sep 4, 2025
…-avila#9359)

* 🔧 fix: Ensure loading state is correctly set when files are empty or in progress

* 🔧 fix: Update ephemeral agent state on file upload error for execute code tool resource

* 🔧 fix: Reset ephemeral agent state for tool when authentication fails

* refactor: Pass conversation prop to FileFormChat and AttachFileChat components
pedrojreis pushed a commit to nosportugal/LibreChat that referenced this pull request Sep 4, 2025
…-avila#9359)

* 🔧 fix: Ensure loading state is correctly set when files are empty or in progress

* 🔧 fix: Update ephemeral agent state on file upload error for execute code tool resource

* 🔧 fix: Reset ephemeral agent state for tool when authentication fails

* refactor: Pass conversation prop to FileFormChat and AttachFileChat components
arbreton pushed a commit to arbreton/LibreChat that referenced this pull request Oct 9, 2025
…-avila#9359)

* 🔧 fix: Ensure loading state is correctly set when files are empty or in progress

* 🔧 fix: Update ephemeral agent state on file upload error for execute code tool resource

* 🔧 fix: Reset ephemeral agent state for tool when authentication fails

* refactor: Pass conversation prop to FileFormChat and AttachFileChat components
Guiraud pushed a commit to Guiraud/LibreChat that referenced this pull request Nov 21, 2025
…-avila#9359)

* 🔧 fix: Ensure loading state is correctly set when files are empty or in progress

* 🔧 fix: Update ephemeral agent state on file upload error for execute code tool resource

* 🔧 fix: Reset ephemeral agent state for tool when authentication fails

* refactor: Pass conversation prop to FileFormChat and AttachFileChat components
patricksn3ll pushed a commit to patricksn3ll/LibreChat that referenced this pull request Dec 11, 2025
…-avila#9359)

* 🔧 fix: Ensure loading state is correctly set when files are empty or in progress

* 🔧 fix: Update ephemeral agent state on file upload error for execute code tool resource

* 🔧 fix: Reset ephemeral agent state for tool when authentication fails

* refactor: Pass conversation prop to FileFormChat and AttachFileChat components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants