🔍 fix: Display File Search Citations Based on Permissions #9454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benverhees
changed the title
Owner
|
thanks for the PR! |
…cluding it in artifact
danny-avila
changed the title
danny-avila
approved these changes
Sep 5, 2025
danny-avila
changed the title
benverhees
commented
Sep 5, 2025
| * @param {IUser} options.user - The user object | ||
| * @param {AppConfig} options.appConfig - The app configuration object | ||
| * @param {GraphRunnableConfig['configurable']} options.metadata - The metadata | ||
| * @param {any} options.toolArtifact - The tool artifact containing structured data |
Owner
There was a problem hiding this comment.
I did intentionally add the JSDoc typing on the right-hand side of the git diff i.e.
* @param {{ [Tools.file_search]: { sources: Object[]; fileCitations: boolean } }} options.toolArtifact - The tool artifact containing structured data
Contributor
Author
There was a problem hiding this comment.
Ah, I was confused, thinking there was a mismatch in naming, but I see now that the toolArtifact contains the file_search 😅
Owner
There was a problem hiding this comment.
no worries, thanks for inspecting the code!
mforman
pushed a commit
to mforman/LibreChat
that referenced
this pull request
Sep 8, 2025
…a#9454) * Make file search citations conditional * refactor: improve permission handling to avoid redundant checks by including it in artifact * chore: reorder imports for better organization and clarity --------- Co-authored-by: Danny Avila <[email protected]>
mforman
pushed a commit
to mforman/LibreChat
that referenced
this pull request
Sep 8, 2025
…a#9454) * Make file search citations conditional * refactor: improve permission handling to avoid redundant checks by including it in artifact * chore: reorder imports for better organization and clarity --------- Co-authored-by: Danny Avila <[email protected]>
arbreton
pushed a commit
to arbreton/LibreChat
that referenced
this pull request
Oct 9, 2025
…a#9454) * Make file search citations conditional * refactor: improve permission handling to avoid redundant checks by including it in artifact * chore: reorder imports for better organization and clarity --------- Co-authored-by: Danny Avila <[email protected]>
Guiraud
pushed a commit
to Guiraud/LibreChat
that referenced
this pull request
Nov 21, 2025
…a#9454) * Make file search citations conditional * refactor: improve permission handling to avoid redundant checks by including it in artifact * chore: reorder imports for better organization and clarity --------- Co-authored-by: Danny Avila <[email protected]>
patricksn3ll
pushed a commit
to patricksn3ll/LibreChat
that referenced
this pull request
Dec 11, 2025
…a#9454) * Make file search citations conditional * refactor: improve permission handling to avoid redundant checks by including it in artifact * chore: reorder imports for better organization and clarity --------- Co-authored-by: Danny Avila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where file search citation markers were being output in file_search results, and the file_search tool description included instructions on using the citation markers for all users regardless of their permissions or configuration settings. The changes make citation functionality conditional based on both the user's
FILE_CITATIONSpermission and whether file citations are enabled in the configuration.Key Changes:
fileCitationsparameter tocreateFileSearchToolfunction to control citation marker outputcheckAccessto verifyFILE_CITATIONSpermission\ue202turn0file${index}) conditional in search resultsProblem Fixed:
The file search tool was including citation anchor markers (e.g.,
\ue202turn0file0,\ue202turn0file1) in file_search results, regardless of permissions or configuration settings. However, the actual UI components that would render these markers as clickable links to documents are only displayed for users with proper permissions and when fileCitations were enabled. This resulted in raw, non-functional citation markers in responses when file citations were disabled in the configuration.Change Type
Testing
Test Process:
Test Configuration:
Checklist
Please delete any irrelevant options.