Skip to content

Conversation

@nhtruong
Copy link
Contributor

These cache keys were identified as dead code - they were being written to but never read from anywhere in the codebase after a recent refactor:

  • STATIC_CONFIG was used as a cache namespace that stored configuration data
  • LIBRECHAT_YAML_CONFIG was the key used within that namespace to store parsed YAML config
  • The cache.set() operation in loadCustomConfig.js stored the config but no cache.get() operations retrieved it
  • Configuration data is already handled through other mechanisms without caching

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

These cache keys were identified as dead code - they were being written to but never read from anywhere in the codebase after a recent refactor:

- STATIC_CONFIG was used as a cache namespace that stored configuration data
- LIBRECHAT_YAML_CONFIG was the key used within that namespace to store parsed YAML config
- The cache.set() operation in loadCustomConfig.js stored the config but no cache.get() operations retrieved it
- Configuration data is already handled through other mechanisms without caching
@danny-avila danny-avila changed the title Remove unused STATIC_CONFIG and LIBRECHAT_YAML_CONFIG cache keys. 🧹 chore: Remove Unused Cache Configuration Keys Sep 10, 2025
@danny-avila danny-avila changed the base branch from main to dev September 10, 2025 22:54
@danny-avila danny-avila merged commit 8d6cb5e into danny-avila:dev Sep 10, 2025
7 checks passed
@nhtruong nhtruong deleted the move_APP_CONFIG branch September 12, 2025 15:05
arbreton pushed a commit to arbreton/LibreChat that referenced this pull request Oct 9, 2025
* Remove unused STATIC_CONFIG and LIBRECHAT_YAML_CONFIG cache keys.

These cache keys were identified as dead code - they were being written to but never read from anywhere in the codebase after a recent refactor:

- STATIC_CONFIG was used as a cache namespace that stored configuration data
- LIBRECHAT_YAML_CONFIG was the key used within that namespace to store parsed YAML config
- The cache.set() operation in loadCustomConfig.js stored the config but no cache.get() operations retrieved it
- Configuration data is already handled through other mechanisms without caching

* # removed tests regarding cache
Guiraud pushed a commit to Guiraud/LibreChat that referenced this pull request Nov 21, 2025
* Remove unused STATIC_CONFIG and LIBRECHAT_YAML_CONFIG cache keys.

These cache keys were identified as dead code - they were being written to but never read from anywhere in the codebase after a recent refactor:

- STATIC_CONFIG was used as a cache namespace that stored configuration data
- LIBRECHAT_YAML_CONFIG was the key used within that namespace to store parsed YAML config
- The cache.set() operation in loadCustomConfig.js stored the config but no cache.get() operations retrieved it
- Configuration data is already handled through other mechanisms without caching

* # removed tests regarding cache
patricksn3ll pushed a commit to patricksn3ll/LibreChat that referenced this pull request Dec 11, 2025
* Remove unused STATIC_CONFIG and LIBRECHAT_YAML_CONFIG cache keys.

These cache keys were identified as dead code - they were being written to but never read from anywhere in the codebase after a recent refactor:

- STATIC_CONFIG was used as a cache namespace that stored configuration data
- LIBRECHAT_YAML_CONFIG was the key used within that namespace to store parsed YAML config
- The cache.set() operation in loadCustomConfig.js stored the config but no cache.get() operations retrieved it
- Configuration data is already handled through other mechanisms without caching

* # removed tests regarding cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants