Skip to content

DAOS-17049 control: Allow graceful shutdown for specific ranks (#16305) #16521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/2.6
Choose a base branch
from

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Jun 17, 2025

The CR checker tool needs to use a graceful shutdown when stopping ranks. It may select a subset of ranks if some are admin-excluded.

  • Remove the limitation that non-forced shutdown may only be used on the whole system, not while specifying ranks.

Features: control recovery

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

The CR checker tool needs to use a graceful shutdown when stopping
ranks. It may select a subset of ranks if some are admin-excluded.

- Remove the limitation that non-forced shutdown may only be used
  on the whole system, not while specifying ranks.

Features: control recovery

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque self-assigned this Jun 17, 2025
@kjacque kjacque requested review from a team as code owners June 17, 2025 15:23
Copy link

github-actions bot commented Jun 17, 2025

Ticket title is 'recovery/ms_membership.py:MSMembershipTest.test_checker_on_admin_excluded - errors with dmg check commands'
Status is 'Awaiting backport'
Labels: '2.6.3rc2,2.6.3rc3,2.6.3rc4,2.6.4rc1,ci-taskforce,ci_2.6_daily,ci_master_daily,daily_test,scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17049

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 17, 2025
@daosbuild3
Copy link
Collaborator

@kjacque
Copy link
Contributor Author

kjacque commented Jun 17, 2025

Looks like the unit test changes are based on #16291, so there is a conflict without that patch.

@daosbuild3
Copy link
Collaborator

@kjacque
Copy link
Contributor Author

kjacque commented Jun 27, 2025

#16291 has landed to the release/2.6 branch, so I've merged that change in and run unit tests locally to verify they now pass.

@daosbuild3
Copy link
Collaborator

@daosbuild3
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.6.4
Development

Successfully merging this pull request may close these issues.

3 participants