This repository was archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Resolve relative URL issue #1455
Copy link
Copy link
Open
Description
When I try to pub build
and have a folder named "include-gh1415", the URI resolver will throw:
[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:34:
Expected ';' after this.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
^^^^^^^
[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:41:
Can't have modifier '-' here.
Try replacing modifier '-' with 'var', 'final', or a type.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
^
[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:3:1:
Library tags not allowed here.
import 'package:angular/core_dom/type_to_uri_mapper.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:00.004174 to compile angular_dart_example|web/include-gh1415/main_static_type_to_uri_mapper.dart.
[Info from Dart2JS]:
Compiling angular_dart_example|web/include-gh1415/main.dart...
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:34:
Expected ';' after this.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
^^^^^^^
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:41:
Can't have modifier '-' here.
Try replacing modifier '-' with 'var', 'final', or a type.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
^
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:3:1:
Library tags not allowed here.
import 'package:angular/core_dom/type_to_uri_mapper.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@chirayuk @dsalsbury please have a look at this
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
vicb commentedon Sep 15, 2014
How to reproduce:
pub build
in the example foldernaomiblack commentedon Oct 7, 2014
@vicb can you make a PR to fix this without rolling back? Is this still an issue?
vicb commentedon Oct 7, 2014
I can't remember having seen a PR fixing that (or any other related issue)
@chirayuk was looking into this (which is why the issue was assigned to him).
naomiblack commentedon Oct 8, 2014
I'm deferring to post-1.0 until someone has time to work on a PR addressing this. Out of scope for 1.0.