[Feature] Enable the option to add comment when defining a new databricks_share
#4802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolfsberzins
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rudolfsberzins
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
reviewed
Jun 26, 2025
Comment on lines
+233
to
+241
| if d.HasChange("comment") { | ||
| _, err = client.Shares.Update(ctx, sharing.UpdateShare{ | ||
| Name: afterSi.Name, | ||
| Comment: afterSi.Comment, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
Why can't we do this update together with Update call below or with update of owner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the option for the user to define a
commentwhen creatingdatabricks_sharewhich will be displayed in Databricks UI for defined share.Additionally, made
share.mddocumentation more consistent with Terraform style.Tests
make testrun locallydocs/folderinternal/acceptance