cmd/fillstruct: broken without modules

[mschneider82]

I dont have go modules in my project (in $GOPATH/src) and trying to fill a struct in a _test.go file, the struct is defined in the same package but not in the _test.go file.

I always get the message:

fillstruct: no struct literal found at selection

When i rollback to commit 654d0ba struct filling in the _test file is working.

client.go :
type X struct {
       Somevalue bool
}


client_test.go:
func TestClient_DoSomeTest(t *testing.T) {
   x := X{} // problem filling struct
}

[klische]

I have the same issue. Even if the struct is defined in the same package, but in a different file, I get the fillstruct: no struct literal found at selection message.

I guess a workaround for now is to copy over struct definitions into the same file and then copy them back over to another file in the same package after using this tool.

@davidrjenni can you please look into this?

[mschneider82]

@klische for me a better workaround is to rollback to the old binary:

cd $GOPATH/src/github.com/davidrjenni/reftools/cmd/fillstruct
git checkout 654d0ba
go build -i

[mschneider82]

@klische you could test my PR / fork.
My PR should be compatible with modules and non-modules...

[davidrjenni]

@mschneider82, @klische sorry for the late response and thank you for the workaround instructions and the PR. I will review the issue and the PR during the weekend. I hope you can still use the tool with the workaround until the issue is resolved.

[mschneider82]

thanks @davidrjenni i am sure that there is a better solution than my hack, but it works for now.. I cannot live with a half-broken fillstruct tool!

[mschneider82]

@davidrjenni have you had some time to look at this?

[klische]

@klische you could test my PR / fork.
My PR should be compatible with modules and non-modules...

I will test your PR tomorrow. Thank you for this :)

[davidrjenni]

@mschneider82 could you please test PR #33? It seems to fix the problem for me.

[davidrjenni]

@klische can you also confirm that the problem is fixed in the current master?

[klische]

@davidrjenni I apologize for the late response. I can confirm it is working! This is fantastic. Thank you so much.

[davidrjenni]

@klische thanks for the feedback!