Skip to content

ref(workflow-e2e): Use default command specified by image#214

Closed
krancour wants to merge 1 commit into
deis:masterfrom
krancour:e2e-use-default-command
Closed

ref(workflow-e2e): Use default command specified by image#214
krancour wants to merge 1 commit into
deis:masterfrom
krancour:e2e-use-default-command

Conversation

@krancour
Copy link
Copy Markdown
Contributor

@krancour krancour commented Apr 8, 2016

This change complements deis/workflow-e2e#157

The idea here is that the e2e test image itself will specify the default command used to kick off the tests. This consolidates responsibility for how the tests are executed into the deis/workflow-e2e repo and reduces the need for future changes to this chart if / as how we execute tests changes.

At the same time, I've eliminated setting the JUNIT env var since that is defaulted to true in the image.

cc @vdice

@vdice
Copy link
Copy Markdown
Member

vdice commented Apr 8, 2016

@krancour I believe we want to leave the workflow-beta1-e2e chart 'immutable' (as it is tied to the quay.io/deis/deis-e2e:v2.0.0-beta1 image). Rather, I propose this change be made in the deis-tests(-parallel) charts here and here.

@jchauncey
Copy link
Copy Markdown
Member

what you submitted is out of date with what is currently in master https://github.com/deis/charts/blob/master/deis-tests/manifests/deis-tests-pod.yaml

@jchauncey
Copy link
Copy Markdown
Member

basically compiling a test binary doesn't allow us to run the tests in parallel so we have to use ginkgo

@krancour
Copy link
Copy Markdown
Contributor Author

krancour commented Apr 8, 2016

@vdice... yup. This was a mistake. You are correct that I modified the wrong chart. (That being said deis-tests seems poorly name, imho. These are specifically Workflow tests.)

First thing on Monday, I'll PR the correct chart. (On my way out the door for the weekend, currently.)

@jchauncey ya. I know. Don't worry. The CMD directive on the image looks like this, which is fine. It does not use statically compiled tests, but rather uses make to execute ginkgo

CMD ["/usr/bin/make", "test-integration"]

@krancour
Copy link
Copy Markdown
Contributor Author

krancour commented Apr 8, 2016

Removing awaiting review tag since some updates to this PR are required.

@krancour
Copy link
Copy Markdown
Contributor Author

Closing in favor of #218

@krancour krancour closed this Apr 11, 2016
@krancour krancour deleted the e2e-use-default-command branch April 11, 2016 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants