ref(workflow-e2e): Use default command specified by image#214
Conversation
|
what you submitted is out of date with what is currently in master https://github.com/deis/charts/blob/master/deis-tests/manifests/deis-tests-pod.yaml |
|
basically compiling a test binary doesn't allow us to run the tests in parallel so we have to use ginkgo |
|
@vdice... yup. This was a mistake. You are correct that I modified the wrong chart. (That being said First thing on Monday, I'll PR the correct chart. (On my way out the door for the weekend, currently.) @jchauncey ya. I know. Don't worry. The |
|
Removing awaiting review tag since some updates to this PR are required. |
|
Closing in favor of #218 |
This change complements deis/workflow-e2e#157
The idea here is that the e2e test image itself will specify the default command used to kick off the tests. This consolidates responsibility for how the tests are executed into the deis/workflow-e2e repo and reduces the need for future changes to this chart if / as how we execute tests changes.
At the same time, I've eliminated setting the
JUNITenv var since that is defaulted to true in the image.cc @vdice