This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(key): ssh key name has to be unique now - migration included that appends a number#1098
Merged
Conversation
helgi
force-pushed
the
ticket_1023
branch
2 times, most recently
from
aff2a68 to
aab6406
Compare
Current coverage is 87.87% (diff: 100%)@@ master #1098 diff @@
==========================================
Files 42 42
Lines 3604 3604
Methods 0 0
Messages 0 0
Branches 611 611
==========================================
+ Hits 3164 3167 +3
+ Misses 290 288 -2
+ Partials 150 149 -1
|
Contributor
|
The CLI could allow a user to optionally specify a name and override the comment in the key? |
Contributor
Author
|
@Joshua-Anderson Yeah, that would be one way to do it and possibly the least invasive. If you look at one of my suggestions in #1023 then I proposed the appending |
… appends a number Fixes deis#1023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only fixes the API side of things and not SDK / CLI - Those are independent of one another as the API has always taken in a
name(asid)#1023 should be split into additional tickets to see if we want to make the UX improvements or just simply require people to modify the comment portion of a key to make it unique for Deis (IMO that's not amazing UX). Thoughts on that?
Fixes #1023