This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(scheduler): use semver package to compare server version#1167
Merged
Conversation
|
@helgi, @mboersma and @kmala are potential reviewers of this pull request based on my analysis of |
kmala
approved these changes
Dec 9, 2016
Member
Author
|
looks like the tests are failing. One sec |
bacongobbler
force-pushed
the
fix-1159
branch
2 times, most recently
from
38fdffd to
0781ee7
Compare
Since the server version can be any valid string type, it is incorrect to assume that the minor version can be converted into a float value. Instead, it is better to compare it as a string using pypa's packaging library, which consists of a core set of utilities for python packages..
bacongobbler
force-pushed
the
fix-1159
branch
from
0781ee7 to
b52013d
Compare
Current coverage is 87.73% (diff: 75.00%)@@ master #1167 diff @@
==========================================
Files 42 42
Lines 3716 3718 +2
Methods 0 0
Messages 0 0
Branches 646 646
==========================================
+ Hits 3260 3262 +2
Misses 299 299
Partials 157 157
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the server version can be any valid string type, it is incorrect to assume that the minor
version can be converted into a float value. Instead, it is better to compare it as a string using
the semver package.
closes #1159.