Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Get timezone from environment variable#1196

Merged
bacongobbler merged 1 commit into
deis:masterfrom
ChillarAnand:master
Jan 11, 2017
Merged

Get timezone from environment variable#1196
bacongobbler merged 1 commit into
deis:masterfrom
ChillarAnand:master

Conversation

@ChillarAnand
Copy link
Copy Markdown
Contributor

@deis-admin
Copy link
Copy Markdown

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

@deis-bot
Copy link
Copy Markdown

@bacongobbler, @helgi and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @ChillarAnand!

@bacongobbler
Copy link
Copy Markdown
Member

If you wouldn't mind amending your commit such that it follows the commit style guide, that would be awesome! That way it'll get picked up by deisrel when we generate the release changelog. Thanks!

@ChillarAnand
Copy link
Copy Markdown
Contributor Author

Amended commit. Thanks @bacongobbler

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2017

Current coverage is 87.29% (diff: 100%)

Merging #1196 into master will not change coverage

@@             master      #1196   diff @@
==========================================
  Files            43         43          
  Lines          3826       3826          
  Methods           0          0          
  Messages          0          0          
  Branches        665        665          
==========================================
  Hits           3340       3340          
  Misses          321        321          
  Partials        165        165          

Powered by Codecov. Last update 0e3e130...93524f2

@mboersma
Copy link
Copy Markdown
Member

Thanks @ChillarAnand! Do we think this change is sufficient, or should we also add this to the deployment and the values.yaml:

- name: "TZ"
  value: "{{ .Values.time_zone }}"

@bacongobbler
Copy link
Copy Markdown
Member

Good point @mboersma. @ChillarAnand would you mind making that change so users can modify the timezone from the chart?

the last line probably needs to be

value: "{{ default "UTC" .Values.time_zone }}"

So that existing charts that don't set the time zone will still work.

If user has set a specific timezone, use that timezone instead of
default UTC.
@ChillarAnand
Copy link
Copy Markdown
Contributor Author

Updated. Thanks @mboersma @bacongobbler

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to change timezone?

6 participants