Get timezone from environment variable#1196
Conversation
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
|
@bacongobbler, @helgi and @mboersma are potential reviewers of this pull request based on my analysis of |
|
If you wouldn't mind amending your commit such that it follows the commit style guide, that would be awesome! That way it'll get picked up by |
|
Amended commit. Thanks @bacongobbler |
Current coverage is 87.29% (diff: 100%)@@ master #1196 diff @@
==========================================
Files 43 43
Lines 3826 3826
Methods 0 0
Messages 0 0
Branches 665 665
==========================================
Hits 3340 3340
Misses 321 321
Partials 165 165
|
|
Thanks @ChillarAnand! Do we think this change is sufficient, or should we also add this to the deployment and the - name: "TZ"
value: "{{ .Values.time_zone }}" |
|
Good point @mboersma. @ChillarAnand would you mind making that change so users can modify the timezone from the chart? the last line probably needs to be So that existing charts that don't set the time zone will still work. |
If user has set a specific timezone, use that timezone instead of default UTC.
|
Updated. Thanks @mboersma @bacongobbler |
closes deis/deis#5113