Skip to content

test(git_push): add concurrent push specs#235

Merged
mboersma merged 1 commit into
deis:masterfrom
mboersma:concurrent-push-tests
Jun 27, 2016
Merged

test(git_push): add concurrent push specs#235
mboersma merged 1 commit into
deis:masterfrom
mboersma:concurrent-push-tests

Conversation

@mboersma
Copy link
Copy Markdown
Member

@mboersma mboersma commented Jun 17, 2016

$ FOCUS_TEST="git push deis master" DEIS_CONTROLLER_URL=your.workflow.host make test-integration
...
Ran 6 of 179 Specs in 364.039 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 173 Skipped 

(Add -v in the Makefile TEST_OPTS to see hilariously interleaved buildpack/dockerfile output.)

Refs #224.

cc: @vdice.

TODO:

  • curl app endpoints in different app specs
  • loop until success in same app specs
  • use filepath for portability

@mboersma mboersma self-assigned this Jun 17, 2016
@deis-bot
Copy link
Copy Markdown

@krancour is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @mboersma!

@vdice
Copy link
Copy Markdown
Member

vdice commented Jun 20, 2016

@mboersma

loop until success in same app specs

Is covered in #237 if we want to pull that logic in...

@mboersma mboersma force-pushed the concurrent-push-tests branch 5 times, most recently from f45d433 to ee3d45c Compare June 27, 2016 18:17
@mboersma mboersma added this to the v2.1 milestone Jun 27, 2016
@mboersma mboersma force-pushed the concurrent-push-tests branch from ee3d45c to 8233306 Compare June 27, 2016 18:45
@mboersma mboersma force-pushed the concurrent-push-tests branch from 8233306 to 98c88aa Compare June 27, 2016 18:59
@mboersma mboersma merged commit 8aba557 into deis:master Jun 27, 2016
@mboersma mboersma deleted the concurrent-push-tests branch June 27, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants