-
Notifications
You must be signed in to change notification settings - Fork 84
[VARIANT] Create low-level Variant library with json_to_variant implementation #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
harshmotw-db
wants to merge
16
commits into
delta-io:main
Choose a base branch
from
harshmotw-db:harsh-motwani_data/variant_library_independent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[VARIANT] Create low-level Variant library with json_to_variant implementation #1030
harshmotw-db
wants to merge
16
commits into
delta-io:main
from
harshmotw-db:harsh-motwani_data/variant_library_independent
+879
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into variant_library_independent
qq: How does this relate to the ongoing work to support variant in arrow-rs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR introduces a low-level Variant library with the
json_to_variant
function which is similar toparse_json
in Spark. The function is written in such a way that the caller owns the memory that the output is written to. The caller needs to implementVariantMemoryManager
with the methodsborrow_value_buffer
,borrow_metadata_buffer
,ensure_value_buffer_size
andensure_metadata_buffer_size
.How was this change tested?
Several unit tests to manually compare the constructed variants with raw bytes. Implementing
variant_to_json
should increase coverage and make more tests easier. While the PR currently contains many tests, we will be adding more tests.TODO: