feat: add timetravel by version number #1044
Open
+53
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonyoo181
approved these changes
Jul 2, 2025
samansmink
force-pushed
the
add-timetravel-by-version-number
branch
from
907cbc3 to
f5e815b
Compare
nicklan
approved these changes
Jul 3, 2025
| pub unsafe extern "C" fn snapshot_at_version( | ||
| path: KernelStringSlice, | ||
| engine: Handle<SharedExternEngine>, | ||
| version: u64, |
There was a problem hiding this comment.
do things work if we make this version: Version (i.e. is cbindgen clever enough to translate that?)
I'd prefer to have this change too if we ever change the type for Version
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 84.74% 83.93% -0.81%
==========================================
Files 92 92
Lines 23407 21097 -2310
Branches 23407 21097 -2310
==========================================
- Hits 19836 17708 -2128
+ Misses 2587 2473 -114
+ Partials 984 916 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
snapshot_at_version, which allows getting a specific snapshot of a table.While this is by itself not super useful to users yet (there's not really a way to list snapshots through the ffi), it will allow testing timetravel in the DuckDB delta extension. A follow up to this PR could be to add:
This PR affects the following public APIs
snapshot_at_versionadded to the ffiHow was this change tested?
using a few extra lines that are added to the existing snapshot ffi function tests.