Skip to content

[Spark] Make DeltaDMLTestUtils agnostic to name/path-based access #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ctring
Copy link
Contributor

@ctring ctring commented Jun 11, 2025

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR is one of a series of PRs aiming to refactor the DML suites such that we can extend the existing suites to test with name-based table access.

Currently, all DML suites are centered around the DeltaDMLTestUtils trait that creates a test table stored in tempPath. In this PR, all path-related elements in this trait will be abstracted out and put into a new specialized trait called DeltaDMLByPathTestUtils.

How was this patch tested?

Existing UTs

Does this PR introduce any user-facing changes?

No

Copy link
Contributor

@ZiyaZa ZiyaZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkorukanti vkorukanti merged commit d5f7bdf into delta-io:master Jun 12, 2025
21 of 22 checks passed
allisonport-db pushed a commit that referenced this pull request Jul 3, 2025
…4808)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [x] Spark
- [ ] Standalone
- [ ] Flink
- [ ] Kernel
- [ ] Other (fill in here)

## Description
This PR is a continuation of
#4738, which introduced
`DeltaDMLByPathTestUtils`. This PR pushes the trait down one more level
of abstractions of the DML suites, with a focus on MERGE INTO suites for
starter.

## How was this patch tested?

Existing UTs

## Does this PR introduce _any_ user-facing changes?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants