Skip to content

[Kernel][Pagination] Ignore JSON Files in PaginatedIterator #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mmmyr
Copy link
Collaborator

@mmmyr mmmyr commented Jun 27, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

How was this patch tested?

Does this PR introduce any user-facing changes?

@mmmyr mmmyr force-pushed the stack/skipJSON branch 2 times, most recently from 4f43a19 to 45e4032 Compare June 27, 2025 06:38
@mmmyr mmmyr changed the title WIP [Kernel][Pagination] Ignore JSON Files in PaginatedIterator Jun 27, 2025
@mmmyr mmmyr force-pushed the stack/skipJSON branch 2 times, most recently from 38065b9 to f08816f Compare June 27, 2025 08:20
scottsand-db pushed a commit that referenced this pull request Jun 27, 2025
## 🥞 Stacked PR
Use this [link](https://github.com/delta-io/delta/pull/4836/files) to
review incremental changes.
-
[**stack/pagination-api**](#4836)
[[Files changed](https://github.com/delta-io/delta/pull/4836/files)]
- [stack/read-page1](#4837)
[[Files
changed](https://github.com/delta-io/delta/pull/4837/files/9d95b4dc82006d2883eb11cee98caeb6899aa4e1..ab5ebd100df54e220cabfbc89eb94a520f3c2db3)]
- [stack/skipJSON](#4844) [[Files
changed](https://github.com/delta-io/delta/pull/4844/files/ab5ebd100df54e220cabfbc89eb94a520f3c2db3..971a98d84f12031099aa35a77e39a8e87a69b05f)]
- [stack/multi-CP](#4845) [[Files
changed](https://github.com/delta-io/delta/pull/4845/files/971a98d84f12031099aa35a77e39a8e87a69b05f..40c4d7d7e0924a7d8225b6a44db7ddbf60b70de6)]
- [stack/sidecar](#4846) [[Files
changed](https://github.com/delta-io/delta/pull/4846/files/40c4d7d7e0924a7d8225b6a44db7ddbf60b70de6..8cbb470df1ab57e1fd8c95c3ecd4c9f0db466390)]

---------
<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [x] Kernel
- [ ] Other (fill in here)

## Description

<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->
This PR introduces new API for Kernel Pagination Support.

## How was this patch tested?

<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->
No implementation yet, no tests. 

## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
Yes.
mmmyr added 12 commits June 27, 2025 23:00
# Conflicts:
#	kernel/kernel-api/src/main/java/io/delta/kernel/internal/ScanBuilderImpl.java
# Conflicts:
#	kernel/kernel-api/src/main/java/io/delta/kernel/internal/ScanBuilderImpl.java
# Conflicts:
#	kernel/kernel-api/src/main/java/io/delta/kernel/internal/PaginatedScanImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant