-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Kernel][Pagination] Ignore JSON Files in PaginatedIterator #4844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mmmyr
wants to merge
12
commits into
delta-io:master
Choose a base branch
from
mmmyr:stack/skipJSON
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+584
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
4f43a19
to
45e4032
Compare
38065b9
to
f08816f
Compare
5 tasks
This was referenced Jun 27, 2025
scottsand-db
pushed a commit
that referenced
this pull request
Jun 27, 2025
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta/pull/4836/files) to review incremental changes. - [**stack/pagination-api**](#4836) [[Files changed](https://github.com/delta-io/delta/pull/4836/files)] - [stack/read-page1](#4837) [[Files changed](https://github.com/delta-io/delta/pull/4837/files/9d95b4dc82006d2883eb11cee98caeb6899aa4e1..ab5ebd100df54e220cabfbc89eb94a520f3c2db3)] - [stack/skipJSON](#4844) [[Files changed](https://github.com/delta-io/delta/pull/4844/files/ab5ebd100df54e220cabfbc89eb94a520f3c2db3..971a98d84f12031099aa35a77e39a8e87a69b05f)] - [stack/multi-CP](#4845) [[Files changed](https://github.com/delta-io/delta/pull/4845/files/971a98d84f12031099aa35a77e39a8e87a69b05f..40c4d7d7e0924a7d8225b6a44db7ddbf60b70de6)] - [stack/sidecar](#4846) [[Files changed](https://github.com/delta-io/delta/pull/4846/files/40c4d7d7e0924a7d8225b6a44db7ddbf60b70de6..8cbb470df1ab57e1fd8c95c3ecd4c9f0db466390)] --------- <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> This PR introduces new API for Kernel Pagination Support. ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> No implementation yet, no tests. ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> Yes.
# Conflicts: # kernel/kernel-api/src/main/java/io/delta/kernel/internal/ScanBuilderImpl.java
# Conflicts: # kernel/kernel-api/src/main/java/io/delta/kernel/internal/ScanBuilderImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?