Skip to content

ETQ Utilisateur d'un lecteur d'écran, je veux que les couples clefs / valeurs soient placés dans une liste de description #11243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025

Conversation

inseo
Copy link
Contributor

@inseo inseo commented Jan 23, 2025

Fix #10249

Remplace les suites de <p> / <div> par des listes de description <dl> dans :

  • la partie "Mandataire" sur la page de récap côté usager ;
  • la partie "Demandeur" sur le PDF d'impression de la démarche côté instructeur et la page de récap' côté usager.

Après


Avant
Capture d’écran 2025-06-06 à 09 24 23
Capture d’écran 2025-06-06 à 09 24 49

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (e107744) to head (e2cf320).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
app/components/dossiers/row_component.rb 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11243      +/-   ##
==========================================
+ Coverage   79.29%   85.17%   +5.88%     
==========================================
  Files        1268     1269       +1     
  Lines       27844    27862      +18     
  Branches     5736     5735       -1     
==========================================
+ Hits        22078    23731    +1653     
+ Misses       5766     4131    -1635     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inseo inseo force-pushed the a11y-list branch 2 times, most recently from ad7f840 to 7f5021c Compare January 23, 2025 15:20
@inseo inseo self-assigned this Feb 13, 2025
@@ -1,11 +1,12 @@
= render Dossiers::RowShowComponent.new(label: 'Email', profile: @profile) do |c|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca va être plus dur que cela de remplacer le RowShowComponent.

En plus de proposer une structure .champ-row > %p.champ-label + .champ-content , le composant ajoute également des pastilles sur les cotés pour indiquer à l'instructeur les changements récents grâce à la classe fr-badge-new.

Ton changement n'intègre pas cette fonctionnalité.

On peut :

  • soit modifier le RowShowComponent pour appliquer ton markup à l'ensemble de l'app.
  • soit créer un component précis pour cette partie qui prend ton markup ET la notion de pastille.

@inseo inseo changed the title ETQ usager, je veux que la hiérarchie de titres d'une demande soit correcte ETQ Utilisateur d'un lecteur d'écran, je veux que les couples clefs / valeurs soient placés dans une liste de description Feb 18, 2025
@inseo inseo marked this pull request as draft February 20, 2025 09:19
@inseo inseo moved this from En cours to Communiqué, ou a ne pas communiqué in The Kanban Feb 27, 2025
@inseo inseo requested a review from LeSim June 6, 2025 07:51
@inseo inseo marked this pull request as ready for review June 6, 2025 07:51
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top, j'ai tout compris

@inseo inseo added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@inseo inseo added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@inseo inseo added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@inseo inseo added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@inseo inseo added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@inseo inseo added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 042abf6 Jun 12, 2025
18 checks passed
@inseo inseo deleted the a11y-list branch June 12, 2025 12:56
@github-project-automation github-project-automation bot moved this from Communiqué, ou a ne pas communiqué to En cours in The Kanban Jun 12, 2025
@inseo inseo moved this from En cours to Communiqué, ou a ne pas communiqué in The Kanban Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Communiqué, ou a ne pas communiqué
Development

Successfully merging this pull request may close these issues.

Présence de liste non structurées comme telles
2 participants