Skip to content

Add concurency test #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2020
Merged

Add concurency test #38

merged 6 commits into from
Jun 22, 2020

Conversation

kemenaran
Copy link
Contributor

This PR adds a test for concurrent uploads.

The default version starts 10 threads, that all attempt to upload concurrently. The mock storage server also has additional latency configured, to simulate the underlying storage server being busy and not responding to requests immediately.

@kemenaran kemenaran force-pushed the add-concurency-test branch from c9c13b0 to e07e8a4 Compare June 2, 2020 15:02
@kemenaran kemenaran force-pushed the add-concurency-test branch from e07e8a4 to c5db6bd Compare June 2, 2020 15:03
@kemenaran kemenaran requested a review from Keirua June 2, 2020 15:04
@kemenaran kemenaran mentioned this pull request Jun 2, 2020
1 task
@kemenaran
Copy link
Contributor Author

kemenaran commented Jun 2, 2020

Ok, donc les deux tests d'intégrations essaient de tourner en parallèle (parce que cargo test est par défaut en parallèle), et donc l'un d'eux se vautre parce que le serveur tourne déjà. C'est logique.

Apparemment, d'après l'équipe de Rust, la solution pour opt-out des tests en parallèle sur certains tests est de manger nos morts utiliser serial_rust pour limiter les runs à un seul en parallèle.

By default cargo runs the tests in parallel. But servers all use the
same ports (3000 and 4000), so we need to force them to run
sequentially.

(Of course we could add support for random server ports, but this does
the job far easily.)
@kemenaran
Copy link
Contributor Author

PR mise à jour, avec :

  • Les tests qui lancent les serveurs sont maintenant séparé des tests de CLI ;
  • Les tests qui lancent les serveurs sont lancé séquentiellement (pour éviter les conflits de ports disponibles).

@kemenaran kemenaran merged commit 39fb4fe into master Jun 22, 2020
@kemenaran kemenaran deleted the add-concurency-test branch June 22, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants