Skip to content

fix(task): accept double hyphen arg immediately following task name #14567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

fix(task): accept double hyphen arg immediately following task name #14567

merged 1 commit into from
May 11, 2022

Conversation

dsherret
Copy link
Member

This is unfortunate, but provides a temporary workaround for a bug in clap.

Closes #14514

@dsherret dsherret requested a review from bartlomieju as a code owner May 11, 2022 16:05
bartlomieju
bartlomieju approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 2da868b into denoland:main May 11, 2022
@dsherret dsherret deleted the fix_deno_task_error_double_hyphen_args branch May 11, 2022 16:58
piscisaureus pushed a commit that referenced this pull request May 12, 2022
@dsherret @piscisaureus
fix(task): accept double hyphen arg immediately following task name (#…
af1bb2d 
…14567)
@Cre3per Cre3per mentioned this pull request Jul 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno task error passing values
2 participants
@dsherret @bartlomieju