fix(ext/net): support IPv6 zone indices in Deno.connect() #31123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
ipv6_zone_index
branch
4 times, most recently
from
3119d9c to
cad0e50
Compare
fraidev
force-pushed
the
ipv6_zone_index
branch
from
cad0e50 to
657a4d6
Compare
littledivy
reviewed
Oct 29, 2025
Member
littledivy
left a comment
littledivy
left a comment
There was a problem hiding this comment.
LGTM. Can you add a unit test for it?
Contributor
Author
Sure! I added some rust test cases in https://github.com/denoland/deno/pull/31123/files#diff-4b2c1e4c760ed2338f71f061fd22dca1f8c777b9b75c99ee1f3557c0f7932563R6444 Do you think we need more unit testing on the JS side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #30956