fix(unstable): don't panic on invalid reported lint range #31261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a lint diagnostic contained an invalid range where the `start` value was bigger than the `end` value, we'd panic when passing the range to dprint. We should ensure that the range is correct right when we're creating the lint diagnostic instead.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic that occurred when a lint diagnostic contained an invalid range where the start value was greater than the end value. The fix adds early validation in the Context.report() method to throw a clear error instead of allowing the invalid range to propagate to dprint.
- Added range validation that throws a RangeError when start > end
- Added a test case to verify the error is thrown for invalid ranges
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/js/40_lint.js | Added validation in the report() method to check if start > end and throw a RangeError with a descriptive message |
| tests/unit/lint_plugin_test.ts | Added import for assertStringIncludes and created a test case that validates the error is thrown when a plugin reports an invalid range |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lint diagnostic contained an invalid range where the
startvalue was bigger than theendvalue, we'd panic when passing the range todprint. We should ensure that the range is correct right when we're creating the lint diagnostic instead.Fixes #31249