feat(node): allow subpath imports that start with '#/' #31520

dsherret · 2025-12-07T01:58:29Z

coderabbitai · 2025-12-07T01:58:44Z

Walkthrough

This change modifies the internal specifier validation in package_imports_resolve_internal to permit specifiers starting with "#/" to continue through the resolution pipeline rather than being rejected early. Previously, the condition rejected any specifier that was exactly "#", started with "#/", or ended with '/'. Now only "#" and trailing '/' are rejected. Accompanying the core change is a new test case (imports_slash_wildcard) that validates this behavior using an ES module with an import map that aliases "#/*" to "./src/*.js", including a main entry point and an exported utility function.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: allowing subpath imports starting with '#/' by removing the validation restriction.
Description check	✅ Passed	The description references a Node.js PR that motivated this change, relating to the feature being implemented.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c27d8f0 and e795fac.

⛔ Files ignored due to path filters (1)

tests/specs/node/imports_slash_wildcard/main.out is excluded by !**/*.out

📒 Files selected for processing (5)

libs/node_resolver/resolution.rs (1 hunks)
tests/specs/node/imports_slash_wildcard/__test__.jsonc (1 hunks)
tests/specs/node/imports_slash_wildcard/main.js (1 hunks)
tests/specs/node/imports_slash_wildcard/package.json (1 hunks)
tests/specs/node/imports_slash_wildcard/src/add.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js}: For JavaScript runtime debugging, enable V8 inspector with --inspect-brk flag and connect Chrome DevTools to chrome://inspect
Use console.log() for debug prints in JavaScript runtime code

Files:

tests/specs/node/imports_slash_wildcard/src/add.js
tests/specs/node/imports_slash_wildcard/main.js

**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.rs: For debugging Rust code, set breakpoints in IDE debuggers (VS Code with rust-analyzer, IntelliJ IDEA) or use lldb directly
Use eprintln!() or dbg!() macros for debug prints in Rust code

Files:

libs/node_resolver/resolution.rs

⚙️ CodeRabbit configuration file

Don't worry about coverage of Rust docstrings. Don't be nitpicky about it. Leave it to the author's judgement if such a documentation is necessary.

Files:

libs/node_resolver/resolution.rs

tests/specs/**/__test__.jsonc

📄 CodeRabbit inference engine (CLAUDE.md)

Spec tests should be created in tests/specs/ with a __test__.jsonc file describing test steps and input files

Files:

tests/specs/node/imports_slash_wildcard/__test__.jsonc

tests/specs/**/{__test__.jsonc,*.out}

📄 CodeRabbit inference engine (CLAUDE.md)

Output assertions in spec tests should use __test__.jsonc inline fields or .out files with special matching syntax: [WILDCARD], [WILDLINE], [WILDCHAR], [WILDCHARS(n)], [UNORDERED_START]/[UNORDERED_END], and [# comment]

Files:

tests/specs/node/imports_slash_wildcard/__test__.jsonc

🧠 Learnings (9)

📓 Common learnings

Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/{__test__.jsonc,*.out} : Output assertions in spec tests should use `__test__.jsonc` inline fields or `.out` files with special matching syntax: `[WILDCARD]`, `[WILDLINE]`, `[WILDCHAR]`, `[WILDCHARS(n)]`, `[UNORDERED_START]`/`[UNORDERED_END]`, and `[# comment]`

Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/*.out : Use `[WILDCHAR]` in spec test output files to match the next single character

Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/*.out : Use `[WILDCARD]` in spec test output files to match 0 or more of any character (can cross newlines)

Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/*.out : Use `[WILDLINE]` in spec test output files to match 0 or more of any character ending at the end of a line