Skip to content

Conversation

@VivienGaluchot
Copy link
Contributor

support android os in esbuild

linked with denoland/esbuild_client#16

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2025

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link

coderabbitai bot commented Dec 7, 2025

Walkthrough

The change extends the esbuild platform target matching logic in cli/tools/bundle/esbuild.rs to recognize Android architecture combinations. Two new match arms are added to map x86_64 and aarch64 architectures on Android to their respective esbuild platform identifiers: "android-x64" and "android-arm64". The control flow and error-handling behavior remain unchanged, with the additions purely expanding the set of supported platform combinations.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description directly relates to the changeset by explaining Android OS support is being added to esbuild and references the linked upstream PR.
Title check ✅ Passed The title 'fix(bundle): support android' directly and clearly describes the main change—adding Android platform support to the esbuild bundler, matching the pull request's core objective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bartlomieju bartlomieju changed the title fix #31517 fix(bundle): support android Dec 8, 2025
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanwhit nathanwhit merged commit f5cb510 into denoland:main Dec 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants