Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 23, 2025

Bumps library/rust from 1.82.0-bookworm to 1.85.0-bookworm.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 23, 2025 16:02
@dependabot dependabot bot added dependencies docker Pull requests that update Docker code labels Feb 23, 2025
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label Feb 23, 2025
@baloo
Copy link

baloo commented Feb 24, 2025

I expect this to fix support for edition 2024.

After we bumped the edition in RustCrypto/formats, dependabot could not update its PRs anymore: RustCrypto/formats#1661 (comment)

Edition 2024 came with rust 1.85

Reviewed the tests breakage, I think they make sense (The version changes in Cargo.lock were from rust .1.83 (rust-lang/cargo#12852)).

@edmorley
Copy link

This will resolve #11691

@robaiken robaiken force-pushed the dependabot/docker/cargo/library/rust-1.85.0-bookworm branch from 336f0c7 to 5304713 Compare February 28, 2025 10:54
@robaiken robaiken self-assigned this Feb 28, 2025
it "returns the correct package manager" do
expect(package_manager.name).to eq "cargo"
expect(package_manager.requirement).to be_nil
expect(package_manager.version.to_s).to eq "1.82.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think checking which rust/cargo versions is a time waste. It also makes updating a pain since we get stuck with specific versions and upgrading becomes more of a hassle than it needs to be

dependabot bot and others added 2 commits February 28, 2025 17:32
Bumps library/rust from 1.82.0-bookworm to 1.85.0-bookworm.

---
updated-dependencies:
- dependency-name: library/rust
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@robaiken robaiken force-pushed the dependabot/docker/cargo/library/rust-1.85.0-bookworm branch from f81fce4 to 21416cb Compare February 28, 2025 17:32
@robaiken robaiken merged commit a4ee018 into main Feb 28, 2025
291 of 342 checks passed
@robaiken robaiken deleted the dependabot/docker/cargo/library/rust-1.85.0-bookworm branch February 28, 2025 18:33
@github-project-automation github-project-automation bot moved this from Ready to Done in Dependabot Feb 28, 2025
@baloo
Copy link

baloo commented Feb 28, 2025

Yup, that fixed that RustCrypto/crypto-bigint#783

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies docker Pull requests that update Docker code L: rust:cargo Rust crates via cargo

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants