[AM] Use a release version that strips ".dev#"#114
Merged
amackillop merged 4 commits intomasterfrom Mar 26, 2020
Merged
Conversation
mohammedri
requested changes
Mar 25, 2020
kyledef
reviewed
Mar 26, 2020
| #!/bin/bash | ||
|
|
||
| export build_version=$(python get_version.py) | ||
| release_version=$(echo $build_version | sed "s/.dev[0-9]*//") |
Contributor
There was a problem hiding this comment.
I think the change is great ... I like the option to use regex to get rid of the dev from the version ... I think @amackillop you should also consider that there are several things that use this version strategy ... I'm wondering what else this will impact....
Contributor
Author
There was a problem hiding this comment.
This particular change only seems to impact which URL is used in the installer to download the release from github. I left the exporting of the original build version in case that is pulled from somewhere later but I don't think that it is.
mohammedri
approved these changes
Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Reviewer:
I feel like we can get rid of the export on line 3 as well. Will do that when everything passes with the current change.