-
Notifications
You must be signed in to change notification settings - Fork 161
Python 3.14 compatibility #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Python 3.14 compatibility #491
Conversation
allburov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tests for py 3.14 failed 🤔 |
Between Python 3.13 and Python 3.14: - glob._Globber was renamed to glob._GlobberBase - Support for passing keyword arguments to pathlib.Path has been removed Guard changes with Python 3.14 version check.
2cea534 to
ec64a43
Compare
|
It seems that many changes have been made to pathlib between Python 3.13 and 3.14 (python/cpython@f5ba74b), which seems to make the changes done in 32cdad0 irrelevant with Python 3.14, especially these lines: Lines 1898 to 1905 in 32cdad0
pathlib._abc.PathBase has been removed and kind of replaced by pathlib.types._ReadablePath, but I don't think _ReadablePath.glob() is a good replacement because it uses a hardcoded globber class _PathGlobber: https://github.com/python/cpython/blob/7cafd76a7fc6e52d93dd11e454a49c4dbebdf080/Lib/pathlib/types.py#L300-L314 The _globber attribute has been removed anyway in python/cpython@f5ba74b, which makes the following lines also irrelevant with Python 3.14: Lines 1599 to 1603 in 32cdad0
@allburov I'm not sure what's the best approach here, so maybe I'll leave this to you. |
|
Would love to see this fix reach artifactory-cleanup. :-) |
|
Related issue #492 |
Hello,
I encountered an error when trying to use this module with Python 3.14, and I tried to suggest the appropriate changes in this PR.