Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Jun 9, 2022

Description

Fix for -

  1. bulk update panic when user does not provides excludes field.
  2. updated secret bulk edit handling - secret' values are encoded & decoded on FE side for save/update operations. Handled this on BE for bulk update.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kartik-579 kartik-579 self-assigned this Jun 9, 2022
@kartik-579 kartik-579 linked an issue Jun 9, 2022 that may be closed by this pull request
2 tasks
@pghildiyal pghildiyal merged commit 8b954d7 into main Jun 9, 2022
@pghildiyal pghildiyal deleted the bulk_update_fix branch June 9, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk Edit failing to update

3 participants