K8s 1.22 compatibility issues #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed grafana datasource name and removed Prometheus datasource * Added chart 4.10 for deployment template * Added new features on chart 4.10 * Added migrations for chart 4.10 * Updated Micro-Services for 1.22 * Changed LTAG for testing Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: Prakarsh <[email protected]>
- Also removed nats-operator dependency
* Added chart for 4.10.0 version * updated chart version * updated ingress.yaml * updated apiversion of PodDisruptionBudget * updated ingress.yaml as pathType is required field * updated hpa spec * updated chart.yaml * Added Environment vlariable fieldRef/fieldPath support * Added initcontainer resources support * Added k8s 1.22 compatible chart changes Co-authored-by: pawan-59 <[email protected]>
- HPA Documentation updated - Ingress Documentation updated
…abs/devtron into k8s-1.22-compatibility
- Updated the ingress section with new format - Updated the ingress legacy format
…abs/devtron into k8s-1.22-compatibility
nishant-d
reviewed
Nov 19, 2021
| grafanaPassword = jsonSelect(operatorSecret, "data.GRAFANA_PASSWORD"); | ||
| azureAccountKey = jsonSelect(operatorSecret, "data.AZURE_ACCOUNT_KEY"); | ||
| postgresSecret = kubectl get secret -n devtroncd postgresql-postgresql; | ||
| enableLegacyApi = jsonSelect(operatorConfigMap, "data.ENABLE_LEGACY_API"); |
Contributor
There was a problem hiding this comment.
we should be introducing flags specific to k8s version so that in future we can support multiple version compatibility
Contributor
There was a problem hiding this comment.
it will be more intuitive for users also
| @@ -0,0 +1,19 @@ | |||
| apiVersion: extensions/v1beta1 | |||
Contributor
There was a problem hiding this comment.
need a specific documentation section for ingress setup
| @@ -1,6 +1,9 @@ | |||
| {{- if $.Values.autoscaling.enabled }} | |||
| --- | |||
| {{- if semverCompare ">=1.16-0" .Capabilities.KubeVersion.GitVersion }} | |||
Contributor
There was a problem hiding this comment.
its good practice to write logic in utils and treat apiVersion as variable in template
pghildiyal
reviewed
Nov 19, 2021
scripts/devtron-reference-helm-charts/reference-chart_3-12-0/app-values.yaml
Show resolved
Hide resolved
pghildiyal
reviewed
Nov 19, 2021
scripts/devtron-reference-helm-charts/reference-chart_3-12-0/app-values.yaml
Show resolved
Hide resolved
pghildiyal
reviewed
Nov 19, 2021
pghildiyal
reviewed
Nov 19, 2021
pghildiyal
reviewed
Nov 19, 2021
pghildiyal
reviewed
Nov 19, 2021
This reverts commit 4c9f578.
|
Thanks for investing time in this! I use K8S 1.22 and egearly await the release of this patch. |
pghildiyal
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves most k8s 1.22 compatibility issues.
Fixes #870
Fixes #869
Fixes #843
Fixes #850
Type of change
How Has This Been Tested?
Tested on various versions of K8s up to k8s 1.22
Checklist:
https://github.com/devtron-labs/silver-surfer has been very helpful in identifying the objects that needed upgrade for making them compatible to kubernetes 1.22