Skip to content

Conversation

@aviralsrivastava01
Copy link
Contributor

@aviralsrivastava01 aviralsrivastava01 commented Dec 3, 2021

Description

Currently only one chart type is supported/visible to user in the deployment template section. Product should be able to support multiple chart types for eg knative, cronjob and others. Also user should be able to add their own helm chart for selection in deployment template.

Fixes #949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test case A
  • Test case B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles

@pghildiyal
Copy link
Contributor

@aviralsrivastava01
Copy link
Contributor Author

aviralsrivastava01 commented Dec 6, 2021

  1. User needs to create configmap with:
    a. Annotation: charts.devtron.ai/data: mount - DONE
    b. Configmap data key is the name of the file and value is the data in gz format - DONE

Blocked: ConfigMap binary files to directory. - DONE

  1. name and version (apiVersion) should be picked from the Chart.yml present in the gz file - DONE
  2. location is same as the name_version (replace any dot with underscore) - DONE
  3. Copy the content of gz file (without enclosing directory) at location - DONE
  4. Whenever user is selecting this chart and version if data is missing at the location repeat step d. mentioned above

@gitguardian
Copy link

gitguardian bot commented Dec 7, 2021

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 47d29ab scripts/devtron-reference-helm-charts/cronjob-chart_1-0-0/env-values.yaml 07:28 November 1st, 2021 View secret
Generic High Entropy Secret f52e72e scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml 07:24 November 9th, 2021 View secret
Generic High Entropy Secret 10ec98e scripts/devtron-reference-helm-charts/cronjob-chart_1-0-0/env-values.yaml 06:56 November 11th, 2021 View secret
Generic High Entropy Secret b7d3bf3 scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml 07:34 December 7th, 2021 View secret
Generic High Entropy Secret dcd4f0d scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml 11:19 December 7th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment

@pghildiyal pghildiyal changed the title Multicharts feat: Multicharts Dec 7, 2021
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@manish-agrawal-ai manish-agrawal-ai merged commit c1da2a1 into main Dec 8, 2021
@manish-agrawal-ai manish-agrawal-ai deleted the multicharts branch December 8, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub issue related to #948

5 participants