-
Notifications
You must be signed in to change notification settings - Fork 557
feat: Multicharts #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multicharts #927
Conversation
Blocked: ConfigMap binary files to directory. - DONE
|
|
| Secret | Commit | Filename | Detected At | |
|---|---|---|---|---|
| Generic High Entropy Secret | 47d29ab | scripts/devtron-reference-helm-charts/cronjob-chart_1-0-0/env-values.yaml | 07:28 November 1st, 2021 | View secret |
| Generic High Entropy Secret | f52e72e | scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml | 07:24 November 9th, 2021 | View secret |
| Generic High Entropy Secret | 10ec98e | scripts/devtron-reference-helm-charts/cronjob-chart_1-0-0/env-values.yaml | 06:56 November 11th, 2021 | View secret |
| Generic High Entropy Secret | b7d3bf3 | scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml | 07:34 December 7th, 2021 | View secret |
| Generic High Entropy Secret | dcd4f0d | scripts/devtron-reference-helm-charts/cronjob-chart_1-2-0/env-values.yaml | 11:19 December 7th, 2021 | View secret |
🛠 How to resolve this
-
Understand the implications of revoking this secret by examining where it is used in your code.
-
Replace and store your secret safely. Learn here the best practices
-
Revoke and rotate this secret
-
If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.
💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.
You are seeing this because you or someone else has authorized GitGuardian to scan pull requests
manish-agrawal-ai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comment
manish-agrawal-ai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
manish-agrawal-ai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Description
Currently only one chart type is supported/visible to user in the deployment template section. Product should be able to support multiple chart types for eg knative, cronjob and others. Also user should be able to add their own helm chart for selection in deployment template.
Fixes #949
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: