LDAP connector - add emailSuffix config option#1380
Merged
Conversation
srenatus
reviewed
Jan 7, 2019
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
🎉 🎈 Nice work, thank you for the contribution. Just some nitpick, please see the inline comments 👇
Contributor
Author
|
Thanks for the feedback! I believe I've addressed all the comments, let me know if anything else is necessary. |
srenatus
approved these changes
Jan 8, 2019
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
Thanks for bearing with me on the style fixes. This is good to go --would you mind squashing the commits? 😃
Contributor
Author
|
Done! |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
LDAP connector - add emailSuffix config option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my organization, we don't have an LDAP mail attribute because email addresses are always based on username. This PR adds an
emailSuffixoption for this use case, where an email domain can be specified in place of a mail attribute.