Skip to content

Add Active Directory and kubelogin integration sample.#1390

Merged
srenatus merged 4 commits into
dexidp:masterfrom
okamototk:activedirectory
Feb 3, 2019
Merged

Add Active Directory and kubelogin integration sample.#1390
srenatus merged 4 commits into
dexidp:masterfrom
okamototk:activedirectory

Conversation

@okamototk
Copy link
Copy Markdown
Contributor

This PR includes Active Directory and kubelogin integration sample.

@ericchiang
Copy link
Copy Markdown
Contributor

Would you mind adding instructions here for how to use this? https://github.com/dexidp/dex/blob/master/Documentation/connectors/ldap.md#getting-started

@srenatus srenatus changed the title Add Active Directory and kubeloing integration sample. Add Active Directory and kubelogin integration sample. Jan 26, 2019
Copy link
Copy Markdown
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments and nitpicks.

Comment thread Documentation/connectors/kubelogin-activedirectory.md Outdated
Comment thread Documentation/connectors/ldap.md Outdated
Comment thread Documentation/connectors/kubelogin-activedirectory.md Outdated
Comment thread Documentation/connectors/kubelogin-activedirectory.md Outdated
Comment thread Documentation/connectors/kubelogin-activedirectory.md Outdated
Comment thread Documentation/connectors/kubelogin-activedirectory.md Outdated
Copy link
Copy Markdown
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 🎈

@srenatus srenatus merged commit b6f4740 into dexidp:master Feb 3, 2019
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
Add Active Directory and kubelogin integration sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants