travis: replace golang 1.10 and 1.11 with 1.12#1457
Merged
Conversation
Contributor
Author
|
cc @JoelSpeed @ericchiang 😉 |
Contributor
|
I'm fine with dropping go 1.11 |
This is because I suspect the gofmt rules change between these versions to make half the travis CI tests fail sometimes? Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/travis/use-go-1.1{1,2}.x
branch
from
2fb7469 to
11913a2
Compare
JoelSpeed
approved these changes
May 28, 2019
Contributor
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
Yep, this looks good, never seen much point in testing between multiple versions anyway! (also 1.11 is painfully slow compared to 1.12)
Contributor
Author
|
ACK, removed all but 1.12.0 ✔️ |
srenatus
changed the title
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
travis: replace golang 1.10 and 1.11 with 1.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because I suspect the gofmt rules change between these versions to
make half the travis CI tests fail sometimes?
Compare this with that 🤕