connectors: refactor filter code into a helper package#1480
Merged
Conversation
srenatus
force-pushed
the
sr/deduplicate-filter-groups
branch
from
f173825 to
8429316
Compare
Contributor
Author
|
Ooops! This is all broken. I'm on it. |
srenatus
force-pushed
the
sr/deduplicate-filter-groups
branch
from
8429316 to
a1d033f
Compare
Contributor
Author
|
✅ Much better if the refactored code is included. |
I hope I didn't miss any :D Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/deduplicate-filter-groups
branch
from
a1d033f to
10611f3
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…oups connectors: refactor filter code into a helper package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope I didn't miss any :D