add connector_id to example app#1496
Merged
srenatus merged 3 commits intoJul 25, 2019
Merged
Conversation
As a piece of "living documentation" for dexidp#1481. Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Now, we'll return a standard error, and have the caller act upon this being an instance of authErr. Also changes the storage.AuthRequest return to a pointer, and returns nil in error cases. Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/add-connector-id-to-example-app
branch
from
cbf37b2 to
8561a66
Compare
JoelSpeed
approved these changes
Jul 25, 2019
Contributor
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
This all makes sense 👍
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…xample-app add connector_id to example app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy to play with the new parameter.
However, it also shows a problem: when trying to login to dex (run via
dex serve examples/config-dev.yaml), and providinglocalasconnector_id, the "back link" will be shown, and go back in browser history one step -- this will not lead you to the connector selection, but to example-app. To be fixed in a follow-up PR (help wanted! 😉)Added two small cleanups, nothing too significant.