Adjusting Makefile so that golint will compile#1509
Merged
Conversation
Closed
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Adjusting Makefile so that `golint` will compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing
make bin/golintone will get an error about go modules and lint. By askinggo install -v ...on the absolute file path, the error goes away.I'm unsure about this nuance of
go installwhere the absolute path will work just fine but the currentREPO_PATHdoes not. Regardless, this does fix it and it does allow dex to use the latest and greatest grpc and lint libraries, unlike my previous PR.Fixes #1506