Skip to content

google: Retrieve all the groups for a user#1627

Merged
bonifaido merged 1 commit into
dexidp:masterfrom
jfrabaute:master
Jan 20, 2020
Merged

google: Retrieve all the groups for a user#1627
bonifaido merged 1 commit into
dexidp:masterfrom
jfrabaute:master

Conversation

@jfrabaute
Copy link
Copy Markdown

The list of groups is paginated (default page is 200), so when a user
has more than 200 groups, only the first 200 are retrieve.
This change is retrieving all the groups for a user by querying all the
pages.

@jfrabaute jfrabaute requested a review from JoelSpeed January 14, 2020 20:35
The list of groups is paginated (default page is 200), so when a user
has more than 200 groups, only the first 200 are retrieve.

This change is retrieving all the groups for a user by querying all the
pages.
@jfrabaute
Copy link
Copy Markdown
Author

For info, if this is merged, I also have a review to do filtering:

jfrabaute@498f19e

(Which seems to be related to @JoelSpeed comment: // TODO (joelspeed): Make desried group key configurable)

Copy link
Copy Markdown
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jfrabaute

@bonifaido bonifaido merged commit aca67b0 into dexidp:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants